linux-kernel - Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Apr 2015 12:25:51 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Tom Zanussi <tom.zanussi@...ux.intel.com>,
	masami.hiramatsu.pt@...achi.com, namhyung@...nel.org,
	andi@...stfloor.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command

On Mon, 06 Apr 2015 18:19:19 +0200
Paul Bolle <pebolle@...cali.nl> wrote:


> But the main reason I added that remark was that recently I ran into a
> few patches where I made annoying mistakes in parsing changes to
> Makefiles. Doing so I wasted my own and other peoples time. So I decided
> to be rather verbose when Makefiles are involved. Just so that people
> can:
> - mock me for not getting basic stuff right;

I hope you don't think I was mocking you. I wasn't.

> - stop paying attention to the rest of my remarks, because chances are I
> didn't understand the patch in question correctly.

I wouldn't put your comments up as useless. I could imagine people
going through and cleaning up header includes, as long as not much
impact is made.

The only issue I can think of that including an unneeded header file
does is to make the compile slightly longer. It's not a major need to
do, but it may be done.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/