linux-kernel - Re: [PATCH] pinctrl: intel: Add Intel Sunrisepoint pin controller and GPIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150407134201.GA1734@lahna.fi.intel.com>
Date:	Tue, 7 Apr 2015 16:42:01 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: intel: Add Intel Sunrisepoint pin controller
 and GPIO support

On Tue, Apr 07, 2015 at 03:18:20PM +0200, Linus Walleij wrote:
> On Mon, Mar 30, 2015 at 4:31 PM, Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> 
> > This driver supports pinctrl/GPIO hardware found on Intel Sunrisepoint (a
> > Skylake PCH) providing users a pinctrl and GPIO interfaces (including GPIO
> > interrupts).
> >
> > The driver is split into core and platform parts so that the same core
> > driver can be reused in other drivers for other Intel GPIO hardware that is
> > based on the same host controller design.
> >
> > Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> 
> How could I possibly resist this gorgeous driver that just
> does everything right? Patch applied for 4.1.

Thanks!

> > +config PINCTRL_INTEL
> > +       tristate
> > +       select PINMUX
> > +       select PINCONF
> > +       select GENERIC_PINCONF
> > +       select GPIOLIB
> > +       select GPIOLIB_IRQCHIP
> 
> Is this opening a refactoring possibility sharing more code/infrastructure
> amongst the Intel drivers or just something that will be used for
> new SoCs going forward?

We are going to use the same core for newer hardware as much as
possible. Hopefully all new SoCs will have GPIO controller which is
based on the same hardware design.

For the existing, unfortunately the hardware differentiates too much
from Sunrisepoint that it does not make much sense to factor them to use
this new core.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/