[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150414194826.1c43aff1@bbrezillon>
Date: Tue, 14 Apr 2015 19:48:26 +0200
From: Boris Brezillon <boris.brezillon@...e-electrons.com>
To: Michael Turquette <mturquette@...aro.org>
Cc: "Nicolas Ferre" <nicolas.ferre@...el.com>,
"Jean-Christophe Plagniol-Villard" <plagnioj@...osoft.com>,
"Alexandre Belloni" <alexandre.belloni@...e-electrons.com>,
"Jonas Andersson" <jonas@...robit.se>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
stable@...r.kernel.org
Subject: Re: [PATCH] clk: at91: pll: fix input range validity check
Hi Mike,
On Sun, 12 Apr 2015 21:37:25 -0700
Michael Turquette <mturquette@...aro.org> wrote:
> Quoting Boris Brezillon (2015-03-28 18:53:43)
> > The PLL impose a certain input range to work correctly, but it appears that
> > this input range does not apply on the input clock (or parent clock) but
> > on the input clock after it has passed the PLL divisor.
> > Fix the implementation accordingly.
> >
> > Cc: <stable@...r.kernel.org> # v3.14+
> > Signed-off-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> > Reported-by: Jonas Andersson <jonas@...robit.se>
>
> Hi Boris,
>
> OK, so this patch along with your two previous submissions kind of
> tackle some of items I mentioned earlier today[0].
>
> Does this patch, combined with your two prior patches[1][2] resolve the
> issue you brought up in your "Propagating clock rate constraints"
> thread[3]?
Unfortunately it doesn't (though it does resolve one of my
issues, so I definitely need that patch :-)).
Take the following case:
1/ clock X takes clock Y as its parent (let's say clock X is a clock
divider)
2/ user U claims clock X and configure X's rate (X then propagates
rate change to Y) and assign a specific supported rate range to X
2/ user V claims clock Y and sets a specific rate
As of today, the constraint U has set on clock X is not propagated to
clock Y, which means user V might configure a rate that is not
fulfilling users V constraint, and the clk infrastructure won't
complain (actually it won't detect it).
Here's what I would expect: if a (MIN -> MAX) constraint is set on clock
X the (MIN * XDIV -> MAX * XDIV) constraint should be propagated to
clock Y.
Am I wrong ?
Best Regards,
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists