linux-kernel - Re: [PATCH] ACPI / scan: Annotate physical_node_lock in acpi_scan_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1429210917.17259.5.camel@misato.fc.hp.com>
Date:	Thu, 16 Apr 2015 13:01:57 -0600
From:	Toshi Kani <toshi.kani@...com>
To:	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	linux-acpi@...r.kernel.org, Xie XiuQi <xiexiuqi@...wei.com>,
	guohanjun@...wei.com, hanjun.guo@...aro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI / scan: Annotate physical_node_lock in
 acpi_scan_is_offline()

On Sat, 2015-04-11 at 01:31 +0200, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> 
> acpi_scan_is_offline() may be called under the physical_node_lock
> of the given device object's parent, so prevent lockdep from
> complaining about that by annotating that instance with
> SINGLE_DEPTH_NESTING.
> 
> Reported-by: Xie XiuQi <xiexiuqi@...wei.com>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Agreed that the issue is likely with the lock-class.  Assuming Xie's
test goes well (we will need to wait for that :),

Reviewed-by: Toshi Kani <toshi.kani@...com>

Thanks,
-Toshi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/