linux-kernel - RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B21756B@SW-EX-MBX02.diasemi.com>
Date:	Fri, 24 Apr 2015 13:36:22 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
CC:	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	DT <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	INPUT <linux-input@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	"Pawel Moll" <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver

On 17 April 2015 17:16 Dmitry Torokhov wrote

> On Fri, Apr 17, 2015 at 01:03:20PM +0100, S Twiss wrote:
> > From: Steve Twiss <stwiss.opensource@...semi.com>
> >
> > Add OnKey driver support for DA9063
> >
> 
> Isn't this almost to the letter identical to da9062 that I just looked
> at? Please find a way to not make a brand new driver for the slightest
> variation of the chip...
> 

Hi Dmitry 

Well, the two chips DA9063 and DA9062 are very different even though their
numbers are sequentially 62 and 63. They are different chips and not a simple
variation. However the OnKey components to these chips *are* functionally
similar which is why I am using the same code.  In this case the 62 OnKey driver
works the same way as 63 OnKey driver. 

Has the combined approach been done before? Are there any examples of this
that you would like me to follow?

I guess I'll drop the OnKey patch for 62 and just concentrate on your comments for
63 instead. After 63 is in a good state then I will work at getting 62 to use a combined
driver.

Regards,
Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/