linux-kernel - RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B217581@SW-EX-MBX02.diasemi.com>
Date:	Fri, 24 Apr 2015 13:45:55 +0000
From:	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
To:	Paul Bolle <pebolle@...cali.nl>,
	"Opensource [Steve Twiss]" <stwiss.opensource@...semi.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Lee Jones <lee.jones@...aro.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	DT <devicetree@...r.kernel.org>,
	David Dajun Chen <david.chen@...semi.com>,
	INPUT <linux-input@...r.kernel.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mark Rutland <mark.rutland@....com>,
	"Pawel Moll" <pawel.moll@....com>,
	Rob Herring <robh+dt@...nel.org>,
	"Support Opensource" <Support.Opensource@...semi.com>
Subject: RE: [RESEND PATCH V2 1/2] input: misc: da9063: OnKey driver

On 18 April 2015 08:55 Paul Bolle wrote:

> There's still a license mismatch left (it probably got lost in the noise
> when I finally noticed that the header comment mentioned the LGPL in
> V1).
> 
> On Fri, 2015-04-17 at 13:03 +0100, S Twiss wrote:
> > + * as published by the Free Software Foundation; either version 2
> > + * of the License, or (at your option) any later version.
> 
> This states the license is GPL v2 or later.
> 
> > +MODULE_LICENSE("GPL v2");
> 
> And, according to include/linux/module.h, this states the license is
> just GPL v2. So I think either the license comment or the license ident
> used in the MODULE_LICENSE() macro needs to change.
> 

Got it. Thanks for your comments.
I have altered the MODULE_LICENSE() to be "GPL" instead of "GPL v2".
That should fix it.

That seems to be a fairly common mistake in the kernel. When I did a
straw-poll,  around 10% of files came up with "GPL v2" and contained
 "any later version" text.

Regards,
Steve.