linux-kernel - Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 May 2015 21:35:28 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	"DHANAPAL, GNANACHANDRAN (G.)" <gdhanapa@...teon.com>
Cc:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"lambert.quentin@...il.com" <lambert.quentin@...il.com>,
	"mdcasey@...bloom.com" <mdcasey@...bloom.com>,
	"julia.lawall@...6.fr" <julia.lawall@...6.fr>,
	"kolbeinnkarls@...il.com" <kolbeinnkarls@...il.com>,
	"himangi774@...il.com" <himangi774@...il.com>,
	"joe@...ches.com" <joe@...ches.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Babu, Viswanathan (V.)" <vbabu3@...teon.com>
Subject: Re: [PATCH] Staging: rtl8192e: Timer setup using macro rather
 assignment

On Mon, May 18, 2015 at 02:44:15PM +0000, DHANAPAL, GNANACHANDRAN (G.) wrote:
> setup_timer is used for timer parameter setup rather than direct
> assignment
> 
> Signed-off-by: Gnanachandran Dhanapal <gdhanapa@...teon.com>

your From: name and Signed-off-by: names are not matching. They should
be same.

> ---
<snip>
> --- a/drivers/staging/rtl8192e/rtllib_module.c
> +++ b/drivers/staging/rtl8192e/rtllib_module.c
> @@ -59,9 +59,8 @@ EXPORT_SYMBOL(rt_global_debug_component);
>  
>  void _setup_timer(struct timer_list *ptimer, void *fun, unsigned long data)
>  {
> -	ptimer->function = fun;
> -	ptimer->data = data;
>  	init_timer(ptimer);
> +	setup_timer(ptimer, fun, data);
setup_timer is calling __setup_timer which is again calling __init_timer
here we already have an init_timer which is also calling __init_timer.
so now __init_timer gets executed two times for one timer. 

regards
sudip
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/