linux-kernel - Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1505212328500.5370@hadrien>
Date:	Thu, 21 May 2015 23:29:18 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Joe Perches <joe@...ches.com>
cc:	Mike Shuey <shuey@...due.edu>, oleg.drokin@...el.com,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
	HPDD-discuss@...1.01.org, lustre-deve@...ts.lustre.org
Subject: Re: [PATCH v4 10/13] staging: lustre: lnet: lnet: checkpatch.pl
 fixes



On Thu, 21 May 2015, Joe Perches wrote:

> On Thu, 2015-05-21 at 15:50 -0400, Mike Shuey wrote:
> > Fix many checkpatch.pl warnings.
> []
> > diff --git a/drivers/staging/lustre/lnet/lnet/acceptor.c b/drivers/staging/lustre/lnet/lnet/acceptor.c
> []
> > @@ -99,38 +99,42 @@ lnet_connect_console_error(int rc, lnet_nid_t peer_nid,
> >  	switch (rc) {
> >  	/* "normal" errors */
> >  	case -ECONNREFUSED:
> > -		CNETERR("Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> > -			libcfs_nid2str(peer_nid),
> > -			&peer_ip, peer_port);
> > +		CNETERR(
> > +			"Connection to %s at host %pI4h on port %d was refused: check that Lustre is running on that node.\n",
> > +			libcfs_nid2str(peer_nid), &peer_ip, peer_port);
>
> These are not improvements and checkpatch messages aren't dicta.
>
> Please don't convert code unless the conversion makes it better
> for a human reader.
>
> These don't.

I haven't looked into it, but perhaps there is a standard kernel printing
function that these could be converted to directly?

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/