linux-kernel - Re: [Y2038] [PATCH v4 06/25] time/posix-timers:Introduce {get, put}_timespec and {get, put}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Jun 2015 11:59:35 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Arnd Bergmann <arnd@...db.de>
cc:	y2038@...ts.linaro.org, Baolin Wang <baolin.wang@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [Y2038] [PATCH v4 06/25] time/posix-timers:Introduce {get,
 put}_timespec and {get, put}_itimerspec

On Thu, 4 Jun 2015, Arnd Bergmann wrote:
> int get_timespec64(struct timespec64 *ts, const struct timespec __user *uts)
> {
> 	struct timespec64 tmp;
> 	int ret;
> 
> 	if (sizeof(tmp) == sizeof(*ts))
> 		return copy_from_user(&tmp, uts, sizeof(*ts)) ? -EFAULT : 0;
> 
> 	ret = copy_from_user(&tmp, uts, sizeof(*ts));
> 	if (ret)
> 		return -EFAULT;
> 
> 	ts->tv_sec = tmp.tv_sec;
> 	ts->tv_nsec = tmp.tv_nsec;
> 
> 	return 0;
> }
> 
> This works fine, but I'd have to change it to copy from a __user
> __kernel_timespec instead of timespec in my system call series, and
> in order to do that, we must ensure that I can change over all callers
> at the same time, so with the function prototype above, we should not
> start using get_timespec64 for anything outside of posix-timers.c.

That's fine I think.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/