linux-kernel - Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7BE8C921-180A-411D-A3C0-5D2A7AE3AB6A@konsulko.com>
Date:	Tue, 23 Jun 2015 10:26:28 +0100
From:	Pantelis Antoniou <pantelis.antoniou@...sulko.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-arm-kernel@...ts.infradead.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Rob Herring <robh+dt@...nel.org>,
	Kumar Gala <galak@...eaurora.org>,
	Mark Brown <broonie@...nel.org>, s.hauer@...gutronix.de,
	linux-api@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	Arnd Bergmann <arnd@...db.de>, sboyd@...eaurora.org,
	Matt Porter <mporter@...sulko.com>, stefan.wahren@...e.com,
	wxt@...k-chips.com
Subject: Re: [PATCH v6 1/9] nvmem: Add a simple NVMEM framework for nvmem providers

Hi Joe,

> On Jun 23, 2015, at 05:52 , Joe Perches <joe@...ches.com> wrote:
> 
> On Tue, 2015-06-23 at 00:08 +0100, Srinivas Kandagatla wrote:
>> This patch adds just providers part of the framework just to enable easy
>> review.
> []
>> include/linux/nvmem-provider.h |  54 ++++++
> 
> Unless there are going to be users of nvmem-provider.h
> outside of the drivers/nvmem directory, perhaps that
> file (and nvmem-consumer.h) should be in drivers/nvmem/
> 
> 

nvmem-consumer.h should be accessible from any driver, no?

And unfortunately nvmem-provider should be accessible too.
There are already eeprom drivers in the eeprom/misc directory that
cannot be moved yet to drivers/nvmem (like at24).

They need the provider definitions while they provide both the old
style interface, and the new NVMEM based one.

When we move them to the drivers/nvmem directory, then yes the
provider header file should move there.

Regards

— Pantelis

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/