linux-kernel - Re: [PATCH] rtc/rtc-opal: Enable alarms only when opal supports tpo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3egkaukno.fsf@oc8180480414.ibm.com>
Date:	Wed, 15 Jul 2015 14:09:15 +1000
From:	Stewart Smith <stewart@...ux.vnet.ibm.com>
To:	Vaibhav Jain <vaibhav@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Michael Neuling <mikey@...ling.org>,
	rtc-linux@...glegroups.com,
	Vaibhav Jain <vaibhav@...ux.vnet.ibm.com>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	Neelesh Gupta <neelegup@...ux.vnet.ibm.com>,
	linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] rtc/rtc-opal: Enable alarms only when opal supports tpo

Vaibhav Jain <vaibhav@...ux.vnet.ibm.com> writes:
> rtc-opal driver provides support for rtc alarms via
> timed-power-on(tpo). However some Power platforms like BML use a fake
> rtc clock and don't support tpo. Such platforms are indicated by the
> missing 'has-tpo' property in the device tree.
>
> Current implementation however enables callback for
> rtc_class_ops.read/set alarm irrespective of the tpo support from the
> platform. This results in a failed opal call when kernel tries to read
> an existing alarms via opal_get_tpo_time during rtc device registration.
>
> This patch fixes this issue by setting opal_rtc_ops.read/set_alarm
> callback pointers only when tpo is supported.
>
> Acked-by: Michael Neuling <mikey@...ling.org>
> Acked-by: Neelesh Gupta <neelegup@...ux.vnet.ibm.com>
> Signed-off-by: Vaibhav Jain <vaibhav@...ux.vnet.ibm.com>

Acked-by: Stewart Smith <stewart@...ux.vnet.ibm.com>

FWIW I'm updating OPAL docs with this. The TPO calls aren't actually
documented :(

In future, it'd be great if there was an accompanying skiboot patch
updating the documentation there too.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/