linux-kernel - RE: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1e303ece500475b8e422d55f82fbffd@SIXPR30MB031.064d.mgd.msft.net>
Date:	Thu, 16 Jul 2015 11:19:01 +0000
From:	Dexuan Cui <decui@...rosoft.com>
To:	David Miller <davem@...emloft.net>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"stephen@...workplumber.org" <stephen@...workplumber.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"apw@...onical.com" <apw@...onical.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"pebolle@...cali.nl" <pebolle@...cali.nl>
Subject: RE: [V2 6/7] hvsock: introduce Hyper-V VM Sockets feature

> From: David Miller
> Sent: Thursday, July 16, 2015 12:19
> 
> From: Dexuan Cui
> Date: Tue, 14 Jul 2015 03:00:48 -0700
> 
> > +	pr_debug("hvsock_sk_destruct: called\n");
> 
> Debug logging just to state that a function is called is not appropriate,
> we have very sophisticated tracing facilities in the kernel that can do
> that transparently, and more.
> 
> Please remove this.
OK. 
 
> > +	if (hvsk->channel) {
> > +		pr_debug("hvsock_sk_destruct: calling vmbus_close()\n");
> 
> Likewise, these kinds of debug logs are totally inappropriate.
OK, I'll remove all the pr_debug() in the patch.
 
> > +static int hvsock_release(struct socket *sock)
> > +{
> > +	/* sock->sk is NULL, if accept() is interrupted by a signal */
> > +	if (sock->sk) {
> > +		__hvsock_release(sock->sk);
> > +		sock->sk = NULL;
> > +	}
> > +
> > +	sock->state = SS_FREE;
> > +	pr_debug("hvsock_release called\n\n");
> 
> Likewise.
OK. Will fix it.

Thanks,
-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/