linux-kernel - Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150904172122.GB2042@l.oracle.com>
Date:	Fri, 4 Sep 2015 13:21:22 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Julien Grall <julien.grall@...rix.com>
Cc:	Roger Pau Monne <roger.pau@...rix.com>,
	linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>,
	David Vrabel <david.vrabel@...rix.com>
Subject: Re: [Xen-devel] [PATCH] xen-blkback: free requests on disconnection

On Fri, Sep 04, 2015 at 02:51:10PM +0100, Julien Grall wrote:
> Hi Roger,
> 
> On 04/09/15 11:08, Roger Pau Monne wrote:
> > Request allocation has been moved to connect_ring, which is called every
> > time blkback connects to the frontend (this can happen multiple times during
> > a blkback instance life cycle). On the other hand, request freeing has not
> > been moved, so it's only called when destroying the backend instance. Due to
> > this mismatch, blkback can allocate the request pool multiple times, without
> > freeing it.
> > 
> > In order to fix it, move the freeing of requests to xen_blkif_disconnect to
> > restore the symmetry between request allocation and freeing.
> > 
> > Reported-by: Julien Grall <julien.grall@...rix.com>
> > Signed-off-by: Roger Pau Monné <roger.pau@...rix.com>
> > Cc: Julien Grall <julien.grall@...rix.com>
> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> > Cc: Boris Ostrovsky <boris.ostrovsky@...cle.com>
> > Cc: David Vrabel <david.vrabel@...rix.com>
> > Cc: xen-devel@...ts.xenproject.org
> 
> The patch is fixing my problem when using UEFI in the guest. Thank you!
> 
> Tested-by: Julien Grall <julien.grall@...rix.com>

Testing it now for regressions and should be sending an git pull next week
for it.

Thanks!
> 
> Regards,
> 
> -- 
> Julien Grall
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@...ts.xen.org
> http://lists.xen.org/xen-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/