linux-kernel - RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <C6287702A945AC47BE5DB5DFD4B5C6DD0194FCC1@SHSMSX104.ccr.corp.intel.com>
Date:	Thu, 10 Sep 2015 07:51:04 +0000
From:	"Zha, Qipeng" <qipeng.zha@...el.com>
To:	Lee Jones <lee.jones@...aro.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"broonie@...nel.org" <broonie@...nel.org>
Subject: RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to
 support Broxton WC PMIC

>>  
>> +#define INIT_REGMAP_IRQ(_irq, _off, _mask)		\
>> +	[_irq] = { .reg_offset = (_off), .mask = (_mask) }
>> +

>No, that's not what I asked.

>Either this macro is going to be useful to *everyone*, or it's probably not useful to *anyone*.  If it's going to exist, it should exist in the core header file, not Intel's own.

Jones, can we keep current change as for intel's own ?  not sure if Mark agree to merge this macro to core regmap header file.
Maybe some driver want to initialize regmap_irq structure with different/customed way.
Thanks.