linux-kernel - Re: [PATCH V2 1/2] mm: Replace nr_node_ids for loop with for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150915075924.GD16220@esperanza>
Date:	Tue, 15 Sep 2015 10:59:24 +0300
From:	Vladimir Davydov <vdavydov@...allels.com>
To:	Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>
CC:	<benh@...nel.crashing.org>, <paulus@...ba.org>,
	<mpe@...erman.id.au>, <anton@...ba.org>,
	<akpm@...ux-foundation.org>, <nacc@...ux.vnet.ibm.com>,
	<gkurz@...ux.vnet.ibm.com>, <grant.likely@...aro.org>,
	<nikunj@...ux.vnet.ibm.com>, <linuxppc-dev@...ts.ozlabs.org>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH V2  1/2] mm: Replace nr_node_ids for loop with
 for_each_node in list lru

On Tue, Sep 15, 2015 at 07:38:36AM +0530, Raghavendra K T wrote:
> The functions used in the patch are in slowpath, which gets called
> whenever alloc_super is called during mounts.
> 
> Though this should not make difference for the architectures with
> sequential numa node ids, for the powerpc which can potentially have
> sparse node ids (for e.g., 4 node system having numa ids, 0,1,16,17
> is common), this patch saves some unnecessary allocations for
> non existing numa nodes.
> 
> Even without that saving, perhaps patch makes code more readable.
> 
> [ Take memcg_aware check outside for_each loop: Vldimir]
> Signed-off-by: Raghavendra K T <raghavendra.kt@...ux.vnet.ibm.com>

Reviewed-by: Vladimir Davydov <vdavydov@...allels.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/