lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151007131911.GD14409@kernel.org> Date: Wed, 7 Oct 2015 10:19:11 -0300 From: Arnaldo Carvalho de Melo <acme@...nel.org> To: Michael Ellerman <mpe@...erman.id.au> Cc: Jiri Olsa <jolsa@...hat.com>, linuxppc-dev@...abs.org, naveen.n.rao@...ux.vnet.ibm.com, Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org, eranian@...gle.com Subject: Re: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks Em Wed, Oct 07, 2015 at 11:46:38AM +1100, Michael Ellerman escreveu: > On Wed, 2015-09-30 at 16:45 -0300, Arnaldo Carvalho de Melo wrote: > > Em Wed, Sep 30, 2015 at 09:09:09PM +0200, Jiri Olsa escreveu: > > > On Wed, Sep 30, 2015 at 11:28:36AM -0700, Sukadev Bhattiprolu wrote: > > > > From e29aeeee7236122c4d807ec9ebc721b5d7d75c8d Mon Sep 17 00:00:00 2001 > > > > From: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> > > > > Date: Thu, 24 Sep 2015 17:53:49 -0400 > > > > Subject: [PATCH v2] perf: Fix build break on powerpc due to sample_reg_masks > > > > > > > > perf_regs.c does not get built on Powerpc as CONFIG_PERF_REGS is false. > > > > So the weak definition for 'sample_regs_masks' doesn't get picked up. > > > > > > > > Adding perf_regs.o to util/Build unconditionally, exposes a redefinition > > > > error for 'perf_reg_value()' function (due to the static inline version > > > > in util/perf_regs.h). So use #ifdef HAVE_PERF_REGS_SUPPORT' around that > > > > function. > > > > > > > > Signed-off-by: Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com> > > > > > > Acked-by: Jiri Olsa <jolsa@...nel.org> > > > > Thanks, applied. > > Is this going to Linus' tree any time soon? > > I have folks pinging me to say that perf is broken on powerpc. Checking this now. - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists