lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 1 Nov 2015 11:11:23 +0000 From: "Kweh, Hock Leong" <hock.leong.kweh@...el.com> To: Borislav Petkov <bp@...en8.de> CC: Matt Fleming <matt@...sole-pimps.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Ong, Boon Leong" <boon.leong.ong@...el.com>, LKML <linux-kernel@...r.kernel.org>, "linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, Sam Protsenko <semen.protsenko@...aro.org>, Peter Jones <pjones@...hat.com>, Andy Lutomirski <luto@...capital.net>, "Roy Franz" <roy.franz@...aro.org>, James Bottomley <James.Bottomley@...senpartnership.com>, Linux FS Devel <linux-fsdevel@...r.kernel.org>, "Fleming, Matt" <matt.fleming@...el.com>, "Anvin, H Peter" <h.peter.anvin@...el.com> Subject: RE: [PATCH v9 1/1] efi: a misc char interface for user to update efi firmware > -----Original Message----- > From: Borislav Petkov [mailto:bp@...en8.de] > Sent: Sunday, November 01, 2015 6:58 PM > > On Sun, Nov 01, 2015 at 10:52:52AM +0000, Kweh, Hock Leong wrote: > > Could you share me your dumb file? I did perform negative test, but I did > > not get these dump stack in dmesg. Thanks. > > I think almost any file works: > > cat /bin/ls > /dev/efi_capsule_loader Ok. Will try this out. > > > > > +#define UPLOAD_DONE -1 > > > > > > Isn't the fact that upload was finished a success message? If so, why is it a > > > negative value? > > > > This is to indicate an upload is done and pending for close(2). If a > subsequence > > write(2) perform, return error. Comments inputted by Matt and Andy. > > But in that case you can return ERR_OCCURRED. UPLOAD_DONE still doesn't > look like a negative value to me as it signals that the upload was done > and thus successful as no errors happened during the upload. > Hmm .... If I combine these 2 flags to become one as "NO_MORE_WRITE_ACTION" to better describing the situation, you Okay with it? Regards, Wilson
Powered by blists - more mailing lists