linux-kernel - Re: [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160114225842.GM19941@pd.tnic>
Date:	Thu, 14 Jan 2016 23:58:43 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
Cc:	tony.luck@...el.com, tglx@...utronix.de, mingo@...hat.com,
	hpa@...or.com, x86@...nel.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] x86/mcheck/AMD: Set MCAX Enable bit

On Thu, Jan 14, 2016 at 04:53:58PM -0600, Aravind Gopalakrishnan wrote:
> Well McaX is name of the field in the MSR. I retained the "SMCA" prefix as

What does that McaX mean, btw?

> these are all still part of the ScalableMCA changes.
> I would prefer if "MCAX" is retained as it is indicative of which bit we are
> touching. So how about just MCAX_EN_OFF ?

If we're going to have a bunch of defines belonging to SMCA, then we're
better having them all start with SMCA_ after all, I guess.

But please make sure you have comments over their definitions explaining
what those bits are. When an outsider is reading those patches and SMCA,
MCAX start appearing left and right, his head most likely starts to
spin.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.