linux-kernel - Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 21 Jan 2016 17:16:40 +0100
From:	Thierry Reding <treding@...dia.com>
To:	Archit Taneja <architt@...eaurora.org>
CC:	<dri-devel@...ts.freedesktop.org>, <a.hajda@...sung.com>,
	<jani.nikula@...ux.intel.com>, <linux-kernel@...r.kernel.org>,
	<airlied@...ux.ie>, <daniel@...ll.ch>, <l.stach@...gutronix.de>,
	<robh@...nel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v4 6/6] drm/dsi: Get DSI host by DT device node

On Thu, Dec 10, 2015 at 06:11:40PM +0530, Archit Taneja wrote:
> mipi_dsi_devices are inherently aware of their host because they
> share a parent-child hierarchy in the device tree.
> 
> non-dsi drivers that create dsi device don't have this data. In order to
> get this information, they require to a phandle to the dsi host in the
> device tree.
> 
> Maintain a list of all the hosts DSI that are currently registered.
> 
> This list will be used to find the mipi_dsi_host corresponding to the
> device_node passed in of_find_mipi_dsi_host_by_node.
> 
> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> Signed-off-by: Archit Taneja <architt@...eaurora.org>
> ---
>  drivers/gpu/drm/drm_mipi_dsi.c | 38 ++++++++++++++++++++++++++++++++++++++
>  include/drm/drm_mipi_dsi.h     |  3 +++
>  2 files changed, 41 insertions(+)

Please be more consistent with the spelling. Abbreviations should be all
capitals. Also s/mipi_dsi_devices/MIPI DSI devices/, and so on.

Otherwise I guess this makes sense.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)