[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <56A85295.6040705@codeaurora.org>
Date: Wed, 27 Jan 2016 10:46:05 +0530
From: Archit Taneja <architt@...eaurora.org>
To: Thierry Reding <treding@...dia.com>
Cc: dri-devel@...ts.freedesktop.org, a.hajda@...sung.com,
jani.nikula@...ux.intel.com, linux-kernel@...r.kernel.org,
airlied@...ux.ie, daniel@...ll.ch, l.stach@...gutronix.de,
robh@...nel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 4/6] drm/dsi: Check for used channels
On 01/21/2016 09:41 PM, Thierry Reding wrote:
> On Thu, Dec 10, 2015 at 06:11:38PM +0530, Archit Taneja wrote:
>> We don't check whether a previously registered mipi_dsi_device under the
>> same host shares the same virtual channel.
>>
>> Before registering, check if any of the registered devices doesn't
>> already have the same virtual channel.
>>
>> This wasn't crucial when all the devices under a host were populated via
>> DT. Now that we also support creating devices manually, we could end up
>> in a situation where a driver tries to create a device with a virtual
>> channel already taken by a device populated in DT.
>>
>> Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
>> Signed-off-by: Archit Taneja <architt@...eaurora.org>
>> ---
>> drivers/gpu/drm/drm_mipi_dsi.c | 26 ++++++++++++++++++++++++--
>> 1 file changed, 24 insertions(+), 2 deletions(-)
>
> I don't think this is necessary. The device name will be composed of the
> host's name, a '.' and the virtual channel ID, and the device core will
> refuse to create two devices with the same name.
That's a good point. I'll drop this patch.
Archit
>
> Thierry
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists