linux-kernel - Re: [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1602111931450.15885@tp.orcam.me.uk>
Date:	Thu, 11 Feb 2016 19:37:12 +0000
From:	"Maciej W. Rozycki" <macro@...tec.com>
To:	Paul Burton <paul.burton@...tec.com>
CC:	Ralf Baechle <ralf@...ux-mips.org>, <linux-mips@...ux-mips.org>,
	"Steven J. Hill" <Steven.Hill@...tec.com>,
	Joshua Kinard <kumba@...too.org>,
	<linux-kernel@...r.kernel.org>,
	Rafał Miłecki <zajec5@...il.com>,
	James Hogan <james.hogan@...tec.com>,
	Markos Chandras <markos.chandras@...tec.com>
Subject: Re: [PATCH] MIPS: tlb-r4k: panic if the MMU doesn't support
 PAGE_SIZE

On Wed, 10 Feb 2016, Paul Burton wrote:

> > diff --git a/arch/mips/mm/tlb-r4k.c b/arch/mips/mm/tlb-r4k.c
> > index 08318ec..4330315 100644
> > --- a/arch/mips/mm/tlb-r4k.c
> > +++ b/arch/mips/mm/tlb-r4k.c
> > @@ -486,6 +487,10 @@ static void r4k_tlb_configure(void)
> >  	 *     be set to fixed-size pages.
> >  	 */
> >  	write_c0_pagemask(PM_DEFAULT_MASK);
> > +	back_to_back_c0_hazard();
> > +	if (read_c0_pagemask() != PM_DEFAULT_MASK)
> > +		panic("MMU doesn't support PAGE_SIZE=0x%lx", PAGE_SIZE);

 I think it would make sense to report here what the minimum/maximum page 
size actually supported is, so that the users know what there might be 
after.

  Maciej