linux-kernel - RE: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2016 16:06:48 +0800
From:	Pankaj DEV <pankaj.dev@...com>
To:	Holger Schurig <holgerschurig@...il.com>
CC:	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"mturquette@...aro.org" <mturquette@...aro.org>,
	"kernel@...inux.com" <kernel@...inux.com>,
	"sboyd@...eaurora.org" <sboyd@...eaurora.org>,
	Laurent MEUNIER <laurent.meunier@...com>,
	"lee.jones@...aro.org" <lee.jones@...aro.org>,
	Maxime COQUELIN <maxime.coquelin@...com>
Subject: RE: [RFC v1] clk: Add debugfs nodes for
 enable/disable/set-rate/set-parent

Hey

The prime motive for clk_set_rate is to set new rate for a clock, since the 'clk_rate' currently available, allows only reading.
To provide reading rate from 'clk_set_rate' is just additional feature.

Regards
Pankaj

>-----Original Message-----
>From: Holger Schurig [mailto:holgerschurig@...il.com]
>Sent: Friday, February 26, 2016 12:54 PM
>To: Pankaj DEV
>Cc: linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org;
>devicetree@...r.kernel.org; mturquette@...aro.org; kernel@...inux.com;
>sboyd@...eaurora.org; Laurent MEUNIER; lee.jones@...aro.org; Maxime
>COQUELIN
>Subject: Re: [RFC v1] clk: Add debugfs nodes for enable/disable/set-rate/set-
>parent
>
>Pankaj Dev <pankaj.dev@...com> writes:
>
>> 1. clk_set_rate : Set new rate to value. Reading returns the current
>> rate
>
>If you can use this to set *and* read it, then "_set_" shouldn't be in the name.
>
>What is wrong with using the existing "clk_rate" for reading/setting the rate?