linux-kernel - Re: [GIT PULL] Ceph fixes for -rc7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 25 Mar 2016 10:34:20 +0100
From:	Ilya Dryomov <idryomov@...il.com>
To:	NeilBrown <neilb@...e.com>
Cc:	Sage Weil <sweil@...hat.com>, torvalds@...ux-foundation.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Ceph Development <ceph-devel@...r.kernel.org>
Subject: Re: [GIT PULL] Ceph fixes for -rc7

On Fri, Mar 25, 2016 at 5:02 AM, NeilBrown <neilb@...e.com> wrote:
> On Sun, Mar 06 2016, Sage Weil wrote:
>
>> Hi Linus,
>>
>> Please pull the following Ceph patch from
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client.git for-linus
>>
>> This is a final commit we missed to align the protocol compatibility with
>> the feature bits.  It decodes a few extra fields in two different messages
>> and reports EIO when they are used (not yet supported).
>>
>> Thanks!
>> sage
>>
>>
>> ----------------------------------------------------------------
>> Yan, Zheng (1):
>>       ceph: initial CEPH_FEATURE_FS_FILE_LAYOUT_V2 support
>
> Just wondering, but was CEPH_FEATURE_FS_FILE_LAYOUT_V2 supposed to have
> exactly the same value as CEPH_FEATURE_NEW_OSDOPREPLY_ENCODING (and
> CEPH_FEATURE_CRUSH_TUNABLES5)??

Yes, that was the point of getting it merged into -rc7.

> Because when I backported this patch (and many others) to some ancient
> enterprise kernel, it caused mounts to fail.  If it really is meant to
> be the same value, then I must have some other backported issue to find
> and fix.

It has to be backported in concert with changes that add support for
the other two bits.  How did mount fail?

Thanks,

                Ilya