linux-kernel - Re: [PATCH v3] device property: don't bother the drivers with struct property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160411095234.GA26606@kuha.fi.intel.com>
Date:	Mon, 11 Apr 2016 12:52:34 +0300
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Lee Jones <lee.jones@...aro.org>, Daniel Mack <daniel@...que.org>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Thierry Reding <treding@...dia.com>,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] device property: don't bother the drivers with struct
 property_set

On Mon, Apr 11, 2016 at 09:20:27AM +0100, Lee Jones wrote:
> On Tue, 29 Mar 2016, Heikki Krogerus wrote:
> 
> > Since device_add_property_set() now always takes a copy of
> > the property_set, and also since the fwnode type is always
> > hard coded to be FWNODE_PDATA, there is no need for the
> > drivers to deliver the entire struct property_set. The
> > function can just create the instance of it on its own and
> > bind the properties from the drivers to it on the spot.
> > 
> > This renames device_add_property_set() to
> > device_add_properties(). The function now takes struct
> > property_entry as its parameter instead of struct
> > property_set.
> > 
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> > Acked-by: Thierry Reding <treding@...dia.com>
> > Acked-by: Lee Jones <lee.jones@...aro.org>
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > ---
> >  arch/arm/mach-pxa/raumfeld.c      | 12 ++++--------

Daniel, I think we just need your ACK for this one.

Otherwise I think we are covered.

> >  arch/arm/mach-tegra/board-paz00.c |  6 +-----
> >  drivers/base/platform.c           | 19 ++++++++++---------
> >  drivers/base/property.c           | 34 +++++++++++++++++++++-------------
> >  drivers/mfd/intel-lpss-acpi.c     | 12 ++----------
> >  drivers/mfd/intel-lpss-pci.c      | 20 ++++----------------
> >  drivers/mfd/intel-lpss.c          |  2 +-
> >  drivers/mfd/intel-lpss.h          |  4 ++--
> >  drivers/mfd/mfd-core.c            |  4 ++--
> >  include/linux/mfd/core.h          |  4 ++--
> >  include/linux/platform_device.h   |  6 +++---
> >  include/linux/property.h          | 15 +++------------
> >  12 files changed, 55 insertions(+), 83 deletions(-)
> 
> What's happening with this patch?  I believe we're still missing
> Acks.  Once they are collected someone needs to create an immutable
> branch and send out a pull-request.

Rafael, have you had time to take a look at this?


Thanks,

-- 
heikki