linux-kernel - Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160503114935.GO6292@sirena.org.uk>
Date:	Tue, 3 May 2016 12:49:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Lu Baolu <baolu.lu@...ux.intel.com>
Cc:	felipe.balbi@...ux.intel.com,
	Mathias Nyman <mathias.nyman@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Lee Jones <lee.jones@...aro.org>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Liam Girdwood <lgirdwood@...il.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 1/7] regulator: fixed: add support for ACPI interface

On Tue, May 03, 2016 at 09:43:58AM +0800, Lu Baolu wrote:
> On 05/02/2016 07:00 PM, Mark Brown wrote:
> > On Fri, Apr 29, 2016 at 02:26:32PM +0800, Lu Baolu wrote:

> >> +	gpiod = gpiod_get(dev, "vbus_en", GPIOD_ASIS);
> >> +	if (IS_ERR(gpiod))
> >> +		return PTR_ERR(gpiod);

> > This is clearly an inappropriate name for the signal in generic code,
> > it's specific to your use case.

> I will change the gpio name to "gpio". Is that okay?

Yes, that looks good (and lines up with DT so hopefully the code can be
shared).

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)