linux-kernel - Re: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken mdelay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1605061131580.3540@nanos>
Date:	Fri, 6 May 2016 11:47:19 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Chen Yu <yu.c.chen@...el.com>
cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, Bin Gao <bin.gao@...el.com>,
	Len Brown <lenb@...nel.org>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	"3 . 14+ # 3 . 14+" <stable@...r.kernel.org>
Subject: Re: [PATCH] x86, tsc: Fix tsc ratio calibration to avoid broken
 mdelay

On Fri, 6 May 2016, yu.c.chen@...el.com wrote:
> From: Chen Yu <yu.c.chen@...el.com>
> 
> Currently we fetch the tsc radio by:
> ratio = (lo >> 8) & 0x1f;
> thus get bit8~bit12 of the MSR_PLATFORM_INFO, however according
> to Intel 64 and IA-32 Architectures Software Developer Manual 35.5,
> the ratio bit should be bit8~bit15, otherwise we might get incorrect
> tsc ratio and cause system hang later(mdelay corrupted).

The resulting issue is that both TSC frequency, which is used for udelay, and
the lapic timer frequency are wrong. mdelay is just the visible damage caused
by that.
 
Thanks,

	tglx