linux-kernel - Re: [PATCH v2] drm/amd/powerplay: use ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160516155350.GQ7910@imgtec.com>
Date:	Mon, 16 May 2016 16:53:50 +0100
From:	Eric Engestrom <eric.engestrom@...tec.com>
To:	Muhammad Falak R Wani <falakreyaz@...il.com>
CC:	David Airlie <airlied@...ux.ie>,
	Nils Wallménius <nils.wallmenius@...il.com>,
	Jammy Zhou <Jammy.Zhou@....com>,
	<linux-kernel@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
	Alex Deucher <alexander.deucher@....com>,
	Rex Zhu <Rex.Zhu@....com>,
	Christian König <christian.koenig@....com>,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH v2] drm/amd/powerplay: use ARRAY_SIZE() to calculate
 array size.

On Fri, May 13, 2016 at 11:06:40PM +0530, Muhammad Falak R Wani wrote:
> It is preferred to use ARRAY_SIZE() for size calculation, instead
> using sizeof(array)/sizeof(*array). It makes the code more readable.
> 
> Signed-off-by: Muhammad Falak R Wani <falakreyaz@...il.com>

Reviewed-by: Eric Engestrom <eric.engestrom@...tec.com>

Thanks, and sorry about before, if I made you feel like you made
a "childish mistake". As Dan said, this is mostly a question of
style: your code was right, it just had an unnecessary bit.

I hope I didn't give you a bad impression of the community, most
people around here have better manners than I :P

Cheers