linux-kernel - Re: [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume asynchronously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160603075603.GE23234@mail.corp.redhat.com>
Date:	Fri, 3 Jun 2016 09:56:03 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	"Fu, Zhonghui" <zhonghui.fu@...ux.intel.com>
Cc:	Jiri Kosina <jikos@...nel.org>, dtor@...omium.org,
	bleung@...omium.org,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	aduggan@...aptics.com, k.kozlowski@...sung.com,
	dianders@...omium.org, gabriele.mzt@...il.com,
	linux-input@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c_hid: enable i2c-hid devices to suspend/resume
 asynchronously

On May 19 2016 or thereabouts, Fu, Zhonghui wrote:
> i2c-hid devices' suspend/resume are usually time-consuming process.
> For example, the touch controller(i2c-ATML1000:00) on ASUS T100 tablet
> takes about 160ms for suspending and 120ms for resuming. This patch
> enables i2c-hid devices to suspend/resume asynchronously. This will
> take advantage of multicore and speed up system suspend/resume process.
> 
> Signed-off-by: Zhonghui Fu <zhonghui.fu@...ux.intel.com>
> ---

In regard with the discussion:
Acked-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>

>  drivers/hid/i2c-hid/i2c-hid.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c
> index 2e021ba..cc41e1e 100644
> --- a/drivers/hid/i2c-hid/i2c-hid.c
> +++ b/drivers/hid/i2c-hid/i2c-hid.c
> @@ -1020,6 +1020,7 @@ static int i2c_hid_probe(struct i2c_client *client,
>  	pm_runtime_get_noresume(&client->dev);
>  	pm_runtime_set_active(&client->dev);
>  	pm_runtime_enable(&client->dev);
> +	device_enable_async_suspend(&client->dev);
>  
>  	ret = i2c_hid_fetch_hid_descriptor(ihid);
>  	if (ret < 0)
> -- 1.7.1
>