linux-kernel - Re: [PATCH] usb: dwc3: fix runtime PM in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eg85769o.fsf@linux.intel.com>
Date:	Fri, 10 Jun 2016 12:16:51 +0300
From:	Felipe Balbi <balbi@...nel.org>
To:	Roger Quadros <rogerq@...com>, grygorii.strashko@...com
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Roger Quadros <rogerq@...com>
Subject: Re: [PATCH] usb: dwc3: fix runtime PM in error path


Hi,

Roger Quadros <rogerq@...com> writes:
> If there is a failure after pm_runtime_enable/get_sync()
> we need to call pm_runtime_disable/put_sync().
>
> Otherwise it will lead to an unbalanced pm_runtime_enable() on the
> subsequent probe if the earlier probe bailed out due to -EPROBE_DEFER.
>
> Signed-off-by: Roger Quadros <rogerq@...com>

where is this supposed to be applied? You're not checking if
pm_runtime_get() failed at all.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (819 bytes)