linux-kernel - Re: [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband bridge support driver for Intel SOC's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160621072339.GT1739@lahna.fi.intel.com>
Date:	Tue, 21 Jun 2016 10:23:39 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	"Tan, Jui Nee" <jui.nee.tan@...el.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"heikki.krogerus@...ux.intel.com" <heikki.krogerus@...ux.intel.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>, "x86@...nel.org" <x86@...nel.org>,
	"ptyser@...-inc.com" <ptyser@...-inc.com>,
	"lee.jones@...aro.org" <lee.jones@...aro.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	"Yong, Jonathan" <jonathan.yong@...el.com>,
	"Yu, Ong Hock" <ong.hock.yu@...el.com>,
	"Voon, Weifeng" <weifeng.voon@...el.com>,
	"Wan Mohamad, Wan Ahmad Zainie" 
	<wan.ahmad.zainie.wan.mohamad@...el.com>
Subject: Re: [PATCH v3 2/3] x86/platform/p2sb: New Primary to Sideband bridge
 support driver for Intel SOC's

On Tue, Jun 21, 2016 at 05:03:20AM +0000, Tan, Jui Nee wrote:
> > Maybe, or make it modular and use MODULE_DEVICE_TABLE(x86cpu, ...) to
> > match the corresponding CPUs.
>
> We need CONFIG_X86_INTEL_NON_ACPI Kconfig option to select CONFIG_PINCTRL.
> This is to solve kbuidbot complaint about kernel configuration, i.e.
> CONFIG_PINCTRL=n. Appreciate if you could advise something on this.

Good point.

Then I guess you might add similar Kconfig option but can you call it
something else than CONFIG_X86_INTEL_NON_ACPI. Perhaps something that
relates to the actual product so distro people can then decide whether
they want to support it or not. Along the lines of CONFIG_X86_INTEL_CE
and so on.