linux-kernel - Re: staging: ks7010: Rename jump labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8f15564a-86c7-0c46-8fe6-1f823d4bdf4f@users.sourceforge.net>
Date:	Thu, 21 Jul 2016 22:11:53 +0200
From:	SF Markus Elfring <elfring@...rs.sourceforge.net>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	Wolfram Sang <wsa@...-dreams.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>,
	kernel-janitors@...r.kernel.org, linux-doc@...r.kernel.org,
	Julia Lawall <julia.lawall@...6.fr>
Subject: Re: staging: ks7010: Rename jump labels

>> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d21ac74a9e3c09b0b01c764e530657e4c85c49#n4326
> 
> "#goto labels aren't indented, allow a single space however"
> 
> Can't be clearer :-)

Should such information from a comment in this script be also
explicitly mentioned in the document "CodingStyle" anyhow?

How should the support for indentation of jump labels with
a single space be expressed in all relevant Linux development documentation?

>> How do you generally think about jump label renaming?
> 
> Renaming from "out0:", "out1:" etc to something meaningful, yes.

I suggest to take another look at such identifiers.

Would you like to support the renaming of a label like "error_out1"
(in the function "ks7010_upload_firmware" for example)?

> Did you have anything else in mind?

Not really for this update suggestion.

Will the software evolution be continued also with information from the topic
"Source code review around jump label usage"?
https://lkml.org/lkml/2015/12/11/378
http://article.gmane.org/gmane.linux.kernel/2106190

Regards,
Markus