linux-kernel - Re: [PATCH 4/6] fs: befs: remove unnecessary *befs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Aug 2016 15:02:57 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Salah Triki <salah.triki@...il.com>, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk
CC:	mhocko@...e.com, vdavydov@...tuozzo.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/6] fs: befs: remove unnecessary *befs_sb variable

On 31/07/16 21:34, Salah Triki wrote:
> Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned
> value by this function is only used once.
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/befs/datastream.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c
> index b68b6f9..343123c 100644
> --- a/fs/befs/datastream.c
> +++ b/fs/befs/datastream.c
> @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb,
>  	struct buffer_head *indir_block;
>  	befs_block_run indir_run;
>  	befs_disk_inode_addr *iaddr_array;
> -	struct befs_sb_info *befs_sb = BEFS_SB(sb);
>  
>  	befs_blocknr_t indir_start_blk =
> -	    data->max_indirect_range >> befs_sb->block_shift;
> +	    data->max_indirect_range >> BEFS_SB(sb)->block_shift;
>  
>  	off_t dbl_indir_off = blockno - indir_start_blk;
>  
> 

This looks to be consistent with other uses of BEFS_SB() when the value is
only used once.

Thanks,
Luis

Acked-by: Luis de Bethencourt <luisbg@....samsung.com>

Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next