linux-kernel - Re: [PATCH 5/6] fs: befs: remove in vain variable assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <579F59DF.7090909@osg.samsung.com>
Date:	Mon, 01 Aug 2016 15:17:03 +0100
From:	Luis de Bethencourt <luisbg@....samsung.com>
To:	Salah Triki <salah.triki@...il.com>, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk
CC:	mhocko@...e.com, vdavydov@...tuozzo.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/6] fs: befs: remove in vain variable assignment

On 31/07/16 21:34, Salah Triki wrote:
> There is no need to init res, since it will be overwitten later by
> befs_fblock2brun().
> 
> Signed-off-by: Salah Triki <salah.triki@...il.com>
> ---
>  fs/befs/linuxvfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index 6bc5b40..2b68c81 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -120,7 +120,7 @@ befs_get_block(struct inode *inode, sector_t block,
>  	struct super_block *sb = inode->i_sb;
>  	befs_data_stream *ds = &BEFS_I(inode)->i_data.ds;
>  	befs_block_run run = BAD_IADDR;
> -	int res = 0;
> +	int res;
>  	ulong disk_off;
>  
>  	befs_debug(sb, "---> befs_get_block() for inode %lu, block %ld",
> 

Looks good.

Thanks Salah,
Luis

Acked-by: Luis de Bethencourt <luisbg@....samsung.com>

Pushed to the befs-next branch:
https://github.com/luisbg/linux-befs/tree/befs-next