linux-kernel - Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160922205218.ndkbjkcyfnfs22jz@breaker.fritz.box>
Date:   Thu, 22 Sep 2016 22:52:18 +0200
From:   becher.jannik@...il.com
To:     Andrey Utkin <andrey_utkin@...tmail.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: wlan-ng: fixed a coding style issue

On Thu, Sep 22, 2016 at 11:32:02PM +0300, Andrey Utkin wrote:
> On Thu, Sep 22, 2016 at 09:11:46PM +0200, Jannik Becher wrote:
> > removed a space after a cast to obtain the coding style.
> > 
> > Signed-off-by: Jannik Becher <Becher.Jannik@...il.com>
> > ---
> >  drivers/staging/wlan-ng/p80211req.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/staging/wlan-ng/p80211req.c b/drivers/staging/wlan-ng/p80211req.c
> > index 40627d5..ecd2fff 100644
> > --- a/drivers/staging/wlan-ng/p80211req.c
> > +++ b/drivers/staging/wlan-ng/p80211req.c
> > @@ -110,7 +110,7 @@ static void p80211req_handle_action(struct wlandevice *wlandev, u32 *data,
> >  ----------------------------------------------------------------*/
> >  int p80211req_dorequest(struct wlandevice *wlandev, u8 *msgbuf)
> >  {
> > -	struct p80211msg *msg = (struct p80211msg *) msgbuf;
> > +	struct p80211msg *msg = (struct p80211msg *)msgbuf;
> >  
> >  	/* Check to make sure the MSD is running */
> >  	if (!((wlandev->msdstate == WLAN_MSD_HWPRESENT &&
> 
> checkpatch.pl shows that in this file there are other occurances of
> style deviations - of same or other kinds. Could you please present work
> on wider scope, e.g. on whole wlan-ng/, or at last making this one file
> to pass checkpatch.pl --strict cleanly?
> 
> Not that I don't appreciate this small achievement, but I believe
> maintainers won't merge this one, exactly because there is more work of
> same kind in the same file.

I always wondered why I shouldn't make more than one change in a patch,
but in all talks I watched they said that it's easier for them to merge
small patches.
So you think I should make one "big" patch and resend it?
Thank you for taking your time.