linux-kernel - Re: Input-gameport: Replace some printk() calls by pr_info() in joydump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69699b11-88fb-93ea-24a2-9ff697b5f439@users.sourceforge.net>
Date:   Sat, 24 Sep 2016 19:20:48 +0200
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Joe Perches <joe@...ches.com>, linux-input@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: Input-gameport: Replace some printk() calls by pr_info() in
 joydump_connect()

> The desired output should not be broken in conversion, which you did.

I dared to change another source code place a bit too much perhaps.

> Do you know how syslog works and why the transformation is not correct.

I imagine that there are chances to improve the software situation a bit more,
aren't there?

> I am also curious as to why you are patching joydump?

The discussed function implementation contains update candidates.

One of them was detected by the execution of a script for the semantic patch
language (Coccinelle software).
I identified further update possibilities after the opportunity for using
the function "kmalloc_array" also in this software module.

> Are you working on extending it?

I attempted just another software refactoring.

Regards,
Markus