linux-kernel - Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 19 Nov 2016 09:49:04 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>
Cc:     "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [char-misc-next 4/4] mei: bus: enable non-blocking RX

On Fri, Nov 18, 2016 at 07:30:25PM +0000, Winkler, Tomas wrote:
> 
> > 
> > On Thu, Nov 17, 2016 at 04:22:24PM +0000, Winkler, Tomas wrote:
> > > > Just make a new function mei_cldev_recv_async() and then call a
> > > > local, static function, that does the work with the correct flag
> > > > set.  That way the developer always knows exactly what is going on.
> > >
> > > We can do a wrapper, but _async() is not proper here maybe
> > > _nonblock(),
> > 
> > Yes, I just guessed at the name :)
> 
> Understood, any how I believe that we should keep patch as is, there is no one
> API _nonblock() function in the whole kernel unlike _async(), 
> nonblock  is always passed in as a flag or Boolean. 

And I'll still argue that this is a horrible api and you can do better.
No need to duplicate the errors of our childhood :)

thanks,

greg k-h