linux-kernel - Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161215194207.GB1741@katana>
Date:   Thu, 15 Dec 2016 20:42:07 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc:     M'boumba Cedric Madianga <cedric.madianga@...il.com>,
        robh+dt@...nel.org, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, linus.walleij@...aro.org,
        patrice.chotard@...com, linux@...linux.org.uk,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/5] i2c: Add STM32F4 I2C driver


> > +	if (ret) {
> > +		dev_err(i2c_dev->dev, "bus not free\n");
> > +		ret = -EBUSY;
> 
> I'm not sure if "bus not free" deserves an error message. Wolfram?

I tend to agree. But I never enforced it up to now, never found the time
to double check if I could/should enforce it.


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)