linux-kernel - Re: [PATCH -next] init/main: Init jump_labels before they are used to build zonelists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20170117123416.6d0caf7544a3508d368ecea1@linux-foundation.org>
Date:   Tue, 17 Jan 2017 12:34:16 -0800
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Vlastimil Babka <vbabka@...e.cz>
Cc:     Stafford Horne <shorne@...il.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Kees Cook <keescook@...omium.org>,
        Jessica Yu <jeyu@...hat.com>, Petr Mladek <pmladek@...e.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Yang Shi <yang.shi@...aro.org>, Tejun Heo <tj@...nel.org>,
        Prarit Bhargava <prarit@...hat.com>,
        Yaowei Bai <baiyaowei@...s.chinamobile.com>,
        Andrey Ryabinin <aryabinin@...tuozzo.com>
Subject: Re: [PATCH -next] init/main: Init jump_labels before they are used
 to build zonelists

> > 
> > Will you be able to look into that? Openrisc doesnt have jump_label
> > support, so its no issue at the moment.
> > 
> > Archs that do have it:
> > 
> > arch/arm64/Kconfig:     select HAVE_ARCH_JUMP_LABEL
> > arch/mips/Kconfig:      select HAVE_ARCH_JUMP_LABEL
> > arch/s390/Kconfig:      select HAVE_ARCH_JUMP_LABEL
> > arch/sparc/Kconfig:     select HAVE_ARCH_JUMP_LABEL if SPARC64
> > arch/tile/Kconfig:      select HAVE_ARCH_JUMP_LABEL
> > arch/x86/Kconfig:       select HAVE_ARCH_JUMP_LABEL
> > arch/arm/Kconfig:       select HAVE_ARCH_JUMP_LABEL if !XIP_KERNEL && !CPU_ENDIAN_BE32 && MMU
> > arch/powerpc/Kconfig:   select HAVE_ARCH_JUMP_LABEL
> > 
> > I looked at a few (arm, tile) and I dont see their arch_jump_label_transform*
> > implementations depending on global state like ideal_nops from x86. They
> > should be ok.
> 
> Thanks, I'll try.
> 
> > If no time, Should you change your patch to not use static keys for
> > build_all_zonelists at least?
> 
> Yes that would be uglier but possible if I find issues or I'm not
> confident enough with the auditing...

We could just revert f5adbdff6a1c40e19 ("mm, page_alloc: convert
page_group_by_mobility_disable to static key")?