linux-kernel - RE: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Feb 2017 19:35:54 +0000
From:   Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>
To:     Colin King <colin.king@...onical.com>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be
 signed int



> -----Original Message-----
> From: Colin King [mailto:colin.king@...onical.com]
> Sent: Tuesday, February 7, 2017 3:51 AM
> To: dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>; James E . J .
> Bottomley <jejb@...ux.vnet.ibm.com>; Martin K . Petersen
> <martin.petersen@...cle.com>; linux-scsi@...r.kernel.org
> Cc: kernel-janitors@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: [PATCH][V2] scsi: aacraid: rcode is unsigned and should be signed int
> 
> EXTERNAL EMAIL
> 
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> aac_fib_send can return -ve error returns and hence rcode should
> be signed. Currently the rcode >= 0 check is always true and -ve
> errors are not being checked.
> 
> Thanks to Dan Carpenter for spotting my original broken fix to this
> issue.
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---

Reviewed-by: Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>