linux-kernel - Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8760kk7jvw.fsf@on-the-bus.cambridge.arm.com>
Date:   Wed, 08 Feb 2017 16:00:19 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Robert Richter <robert.richter@...ium.com>
Cc:     Shanker Donthineni <shankerd@...eaurora.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation

On Wed, Feb 08 2017 at  3:36:58 pm GMT, Robert Richter <robert.richter@...ium.com> wrote:
> On 08.02.17 09:31:00, Shanker Donthineni wrote:
>> In teardown path, code is still calling 'kfree(its->cmd_base)' to free
>> memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ).
>
> Hmm, right. This is later removed in the series, but should be part of
> this patch. Should I respin this one?

Nope, I've hacked it.

Thanks,

	M.
-- 
Jazz is not dead, it just smell funny.