linux-kernel - Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170209014507.GA565@b29397-desktop>
Date:   Thu, 9 Feb 2017 09:45:07 +0800
From:   Peter Chen <hzpeterchen@...il.com>
To:     Vivek Gautam <vivek.gautam@...eaurora.org>
Cc:     Peter Chen <peter.chen@....com>,
        Greg KH <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Ulf Hansson <ulf.hansson@...aro.org>, broonie@...nel.org,
        sre@...nel.org, robh+dt <robh+dt@...nel.org>, shawnguo@...nel.org,
        rjw@...ysocki.net, dbaryshkov@...il.com,
        Heiko Stübner <heiko@...ech.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>, p.zabel@...gutronix.de,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Pawel Moll <pawel.moll@....com>,
        Mark Rutland <mark.rutland@....com>,
        Linux USB Mailing List <linux-usb@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, s.hauer@...gutronix.de,
        mail@...iej.szmigiero.name, troy.kisky@...ndarydevices.com,
        festevam@...il.com, oscar@...andei.net,
        Stephen Boyd <stephen.boyd@...aro.org>,
        linux-pm@...r.kernel.org, stillcompiling@...il.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        mka@...omium.org, vaibhav.hiremath@...aro.org,
        gary.bisson@...ndarydevices.com, Hans Verkuil <hverkuil@...all.nl>,
        krzk@...nel.org, Sriram Dash <sriram.dash@....com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>
Subject: Re: [PATCH v12 6/9] usb: xhci: use bus->sysdev for DMA configuration

On Wed, Feb 08, 2017 at 05:27:31PM +0530, Vivek Gautam wrote:
> Hi,
> 
> 
> On Mon, Feb 6, 2017 at 2:43 PM, Peter Chen <peter.chen@....com> wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> >
> > For xhci-hcd platform device, all the DMA parameters are not
> > configured properly, notably dma ops for dwc3 devices. So, set
> > the dma for xhci from sysdev. sysdev is pointing to device that
> > is known to the system firmware or hardware.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Signed-off-by: Sriram Dash <sriram.dash@....com>
> > Tested-by: Baolin Wang <baolin.wang@...aro.org>
> > Tested-by: Vivek Gautam <vivek.gautam@...eaurora.org>
> > Tested-by: Alexander Sverdlin <alexander.sverdlin@...ia.com>
> > Signed-off-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> > ---
> 
> This patch doesn't work for me anymore on db820c target [1].
> While the same kernel with reverts of patches [2] [3] and an older
> patch [4] by Grygorii Strashko works [5].
> 
> [1] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c-nonworking
> [2] 8c9f2de459c7 usb: dwc3: Do not set dma coherent mask
> [3] d64ff406e51e usb: dwc3: use bus->sysdev for DMA configuration
> [4] https://lkml.org/lkml/2016/4/25/813
> [5] https://github.com/vivekgautam1/linux/tree/linux-v4.10-rc7-usb-db820c
> 
> 

The [2] and [3] have already at mainline, you may talk with Felipe about
it.

-- 

Best Regards,
Peter Chen