linux-kernel - Re: [PATCH v3] statx: optimize copy of struct statx to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17226.1489309913@warthog.procyon.org.uk>
Date:   Sun, 12 Mar 2017 09:11:53 +0000
From:   David Howells <dhowells@...hat.com>
To:     Eric Biggers <ebiggers3@...il.com>
Cc:     dhowells@...hat.com, linux-fsdevel@...r.kernel.org,
        Al Viro <viro@...iv.linux.org.uk>,
        linux-kernel@...r.kernel.org, Eric Biggers <ebiggers@...gle.com>
Subject: Re: [PATCH v3] statx: optimize copy of struct statx to userspace

Eric Biggers <ebiggers3@...il.com> wrote:

> +static int cp_statx(const struct kstat *stat, struct statx __user *buffer)
> ...
> +	struct statx tmp;

This function needs to be "noinline" as tmp is big.

> -	return statx_set_result(&stat, buffer);
> +
> +	return cp_statx(&stat, buffer);

Can you leave it as statx_set_result rather than renaming it to cp_statx?

David