linux-kernel - Re: [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 15 Jun 2017 09:51:59 +0200
From:   Heiko Stübner <heiko@...ech.de>
To:     Frank Wang <frank.wang@...k-chips.com>
Cc:     robh+dt@...nel.org, ulf.hansson@...aro.org, mark.rutland@....com,
        linux-arm-kernel@...ts.infradead.org,
        linux-rockchip@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org,
        charles.chen@...k-chips.com, kevan.lan@...k-chips.com,
        huangtao@...k-chips.com, finley.xiao@...k-chips.com,
        david.wu@...k-chips.com, shawn.lin@...k-chips.com,
        wmc@...k-chips.com
Subject: Re: [PATCH 2/6] Documentation: rockchip-dw-mshc: add description for rk3228

Hi Frank,

Am Donnerstag, 15. Juni 2017, 15:16:16 CEST schrieb Frank Wang:
> From: Shawn Lin <shawn.lin@...k-chips.com>
> 
> Add "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc" for
> dwmmc on rk322x platform.
> 
> Signed-off-by: Shawn Lin <shawn.lin@...k-chips.com>
> ---
>  Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt index
> 520d61d..ce30dff 100644
> --- a/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> +++ b/Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt
> @@ -15,6 +15,7 @@ Required Properties:
>  	- "rockchip,rk3288-dw-mshc": for Rockchip RK3288
>  	- "rockchip,rv1108-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip
> RV1108 - "rockchip,rk3036-dw-mshc", "rockchip,rk3288-dw-mshc": for Rockchip
> RK3036 +	- "rockchip,rk3228-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK322X - "rockchip,rk3368-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK3368 - "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc": for
> Rockchip RK3399

you might want to rebase this patch on top of Ulfs next branch [0],
as there is also the support for the rk3328 in there now.

Otherwise looks good to me, so
Reviewed-by: Heiko Stuebner <heiko@...ech.de>



[0] https://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git/log/?h=next