linux-kernel - Re: [PATCH] tracing/ring_buffer: Try harder to allocate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170711061245.GC24852@dhcp22.suse.cz>
Date:   Tue, 11 Jul 2017 08:12:45 +0200
From:   Michal Hocko <mhocko@...nel.org>
To:     Joel Fernandes <joelaf@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kernel-team@...roid.com,
        linux-mm@...ck.org, Alexander Duyck <alexander.h.duyck@...el.com>,
        Mel Gorman <mgorman@...e.de>, Hao Lee <haolee.swjtu@...il.com>,
        Vladimir Davydov <vdavydov.dev@...il.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Joonsoo Kim <iamjoonsoo.kim@....com>,
        Tim Murray <timmurray@...gle.com>,
        Ingo Molnar <mingo@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>, stable@...r.kernel.org
Subject: Re: [PATCH] tracing/ring_buffer: Try harder to allocate

On Mon 10-07-17 23:05:00, Joel Fernandes wrote:
> ftrace can fail to allocate per-CPU ring buffer on systems with a large
> number of CPUs coupled while large amounts of cache happening in the
> page cache. Currently the ring buffer allocation doesn't retry in the VM
> implementation even if direct-reclaim made some progress but still
> wasn't able to find a free page. On retrying I see that the allocations
> almost always succeed. The retry doesn't happen because __GFP_NORETRY is
> used in the tracer to prevent the case where we might OOM, however if we
> drop __GFP_NORETRY, we risk destabilizing the system if OOM killer is
> triggered. To prevent this situation, use the __GFP_RETRY_MAYFAIL flag
> introduced recently [1].
> 
> Tested the following still succeeds without destabilizing a system with
> 1GB memory.
> echo 300000 > /sys/kernel/debug/tracing/buffer_size_kb
> 
> [1] https://marc.info/?l=linux-mm&m=149820805124906&w=2

Yes this is the correct usage of the new flag.

> Cc: Alexander Duyck <alexander.h.duyck@...el.com>
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Hao Lee <haolee.swjtu@...il.com>
> Cc: Vladimir Davydov <vdavydov.dev@...il.com>
> Cc: Johannes Weiner <hannes@...xchg.org>
> Cc: Joonsoo Kim <iamjoonsoo.kim@....com>
> Cc: Michal Hocko <mhocko@...nel.org>
> Cc: Tim Murray <timmurray@...gle.com>
> Cc: Ingo Molnar <mingo@...hat.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: stable@...r.kernel.org

I do not think stable tag is appropriate. The new flag hasn't been
merged yet and it is not a stable material.

> Signed-off-by: Joel Fernandes <joelaf@...gle.com>

Feel free to add
Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  kernel/trace/ring_buffer.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c
> index 4ae268e687fe..529cc50d7243 100644
> --- a/kernel/trace/ring_buffer.c
> +++ b/kernel/trace/ring_buffer.c
> @@ -1136,12 +1136,12 @@ static int __rb_allocate_pages(long nr_pages, struct list_head *pages, int cpu)
>  	for (i = 0; i < nr_pages; i++) {
>  		struct page *page;
>  		/*
> -		 * __GFP_NORETRY flag makes sure that the allocation fails
> -		 * gracefully without invoking oom-killer and the system is
> -		 * not destabilized.
> +		 * __GFP_RETRY_MAYFAIL flag makes sure that the allocation fails
> +		 * gracefully without invoking oom-killer and the system is not
> +		 * destabilized.
>  		 */
>  		bpage = kzalloc_node(ALIGN(sizeof(*bpage), cache_line_size()),
> -				    GFP_KERNEL | __GFP_NORETRY,
> +				    GFP_KERNEL | __GFP_RETRY_MAYFAIL,
>  				    cpu_to_node(cpu));
>  		if (!bpage)
>  			goto free_pages;
> @@ -1149,7 +1149,7 @@ static int __rb_allocate_pages(long nr_pages, struct list_head *pages, int cpu)
>  		list_add(&bpage->list, pages);
>  
>  		page = alloc_pages_node(cpu_to_node(cpu),
> -					GFP_KERNEL | __GFP_NORETRY, 0);
> +					GFP_KERNEL | __GFP_RETRY_MAYFAIL, 0);
>  		if (!page)
>  			goto free_pages;
>  		bpage->page = page_address(page);
> -- 
> 2.13.2.725.g09c95d1e9-goog

-- 
Michal Hocko
SUSE Labs