linux-kernel - Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a8c14aab-5d90-8c9f-7bc9-bfe26f9d839e@linaro.org>
Date:   Thu, 13 Jul 2017 14:12:03 +0800
From:   Alex Shi <alex.shi@...aro.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     peterz@...radead.org, mingo@...hat.com, corbet@....net,
        "open list:LOCKING PRIMITIVES" <linux-kernel@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        Sebastian Siewior <bigeasy@...utronix.de>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Juri Lelli <juri.lelli@....com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 3/3] rtmutex: remove unnecessary adjust prio



On 07/12/2017 10:14 PM, Steven Rostedt wrote:
> On Tue, 11 Jul 2017 22:39:24 +0800
> Alex Shi <alex.shi@...aro.org> wrote:
> 
>> Any comments for this little change? It's passed on 0day testing.
> 
> I think the problem was that this was a third patch after two
> documentation patches. Where, people put documentation review at the
> bottom of their priority list.
> 
> This should have been sent as separate patch on its own.
> 

Got it. I will resend it.

<snip>...

> 
> Interesting, I did some git mining and this was added with the original
> entry of the rtmutex.c (23f78d4a0). Looking at even that version, I
> don't see the purpose of adjusting the task prio here. It is done
> before anything changes in the task.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Thanks Steven!

Regards
Alex