linux-kernel - Re: [PATCH 2/2] staging: typec: tcpm: explicit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20170817175414.GA32163@kroah.com>
Date:   Thu, 17 Aug 2017 10:54:14 -0700
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Badhri Jagan Sridharan <badhri@...gle.com>
Cc:     Guenter Roeck <linux@...ck-us.net>, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] staging: typec: tcpm: explicit_contract is always
 established

On Tue, Aug 15, 2017 at 04:23:39PM -0700, Badhri Jagan Sridharan wrote:
> While in SNK_READY state, the explicit_contract seems to be
> set to true irrespective of whether an explicit contract
> was established for the current connection. TCPM also seems
> to report the pwr_opmode as TYPEC_PWR_MODE_PD always once
> the port gets into SNK_READY state. This isn't completely
> true as port gets into the SNK_READY state for non-pd
> type-c ports as well.
> 
> This patch sets the explicit_contract flag only when
> the PS_READY message is received and the vbus has been
> detected by the port controller.
> 
> Signed-off-by: Badhri Jagan Sridharan <Badhri@...gle.com>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  drivers/staging/typec/tcpm.c | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

This patch doesn't apply to the tree now that Guenter's other patches
are applied :(

Please rebase and resend.

thanks,

greg k-h