linux-kernel - Re: [PATCH v3 03/11] staging: typec: fusb302: Set max supply voltage to 5V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 30 Aug 2017 06:37:22 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Hans de Goede <hdegoede@...hat.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Wolfram Sang <wsa@...-dreams.de>,
        Sebastian Reichel <sre@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org, Liam Breck <liam@...workimprov.net>,
        Tony Lindgren <tony@...mide.com>, linux-pm@...r.kernel.org,
        devel@...verdev.osuosl.org,
        "Yueyao (Nathan) Zhu" <yueyao@...gle.com>
Subject: Re: [PATCH v3 03/11] staging: typec: fusb302: Set max supply voltage
 to 5V

On 08/30/2017 02:48 AM, Hans de Goede wrote:
> Anything higher then 5V may damage hardware not capable of it, so
> the only sane default here is 5V. If a board is able to handle a
> higher voltage that should come from board specific data such as
> device-tree and not be hard coded into the fusb302 code.
> 
> Cc: "Yueyao (Nathan) Zhu" <yueyao@...gle.com>
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/staging/typec/fusb302/fusb302.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/typec/fusb302/fusb302.c b/drivers/staging/typec/fusb302/fusb302.c
> index 03a3809d18f0..6baed06a3c0d 100644
> --- a/drivers/staging/typec/fusb302/fusb302.c
> +++ b/drivers/staging/typec/fusb302/fusb302.c
> @@ -1187,9 +1187,9 @@ static const struct tcpc_config fusb302_tcpc_config = {
>   	.nr_src_pdo = ARRAY_SIZE(src_pdo),
>   	.snk_pdo = snk_pdo,
>   	.nr_snk_pdo = ARRAY_SIZE(snk_pdo),
> -	.max_snk_mv = 9000,
> +	.max_snk_mv = 5000,
>   	.max_snk_ma = 3000,
> -	.max_snk_mw = 27000,
> +	.max_snk_mw = 15000,
>   	.operating_snk_mw = 2500,
>   	.type = TYPEC_PORT_DRP,
>   	.default_role = TYPEC_SINK,
>