linux-kernel - Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1507177560.4434.17.camel@perches.com>
Date:   Wed, 04 Oct 2017 21:26:00 -0700
From:   Joe Perches <joe@...ches.com>
To:     Srinivasan Shanmugam <srinivasan.rns@...il.com>,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: Externs should be avoided in .C file

On Wed, 2017-10-04 at 19:24 +0200, Srinivasan Shanmugam wrote:
> Removed warning from 0001-Staging-rtl8723bs-Externs-should-be-avoided-in-.C-fi.patch file after running checkpatch.pl
> 
> Signed-off-by: Srinivasan Shanmugam <srinivasan.rns@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index c0b501e..6b5e48c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1226,7 +1226,8 @@ sint validate_recv_ctrl_frame(struct adapter *padapter, union recv_frame *precv_
>  
>  union recv_frame *recvframe_chk_defrag(struct adapter *padapter, union recv_frame *precv_frame);
>  
> -static sint validate_recv_mgnt_frame(struct adapter *padapter, union recv_frame *precv_frame)
> +static int validate_recv_mgnt_frame(struct adapter *padapter,
> +				    union recv_frame *precv_frame)
>  {
>  	/* struct mlme_priv *pmlmepriv = &adapter->mlmepriv; */
>  

This patch does not match the commit message.

This patch changes the return from sint to int and does
some 80 column wrapping.