linux-kernel - Re: [PATCH 1/2] mm: Introduce wrapper to access mm->nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 Oct 2017 13:10:13 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Mike Kravetz <mike.kravetz@...cle.com>
Cc:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
        Michal Hocko <mhocko@...nel.org>
Subject: Re: [PATCH 1/2] mm: Introduce wrapper to access mm->nr_ptes

On Wed, Oct 04, 2017 at 11:35:47AM -0700, Mike Kravetz wrote:
> On 10/04/2017 09:36 AM, Kirill A. Shutemov wrote:
> > @@ -813,7 +813,7 @@ static struct mm_struct *mm_init(struct mm_struct *mm, struct task_struct *p,
> >  	init_rwsem(&mm->mmap_sem);
> >  	INIT_LIST_HEAD(&mm->mmlist);
> >  	mm->core_state = NULL;
> > -	atomic_long_set(&mm->nr_ptes, 0);
> > +	mm_nr_ptes_init(mm);
> >  	mm_nr_pmds_init(mm);
> >  	mm_nr_puds_init(mm);
> >  	mm->map_count = 0;
> > @@ -869,9 +869,9 @@ static void check_mm(struct mm_struct *mm)
> >  					  "mm:%p idx:%d val:%ld\n", mm, i, x);
> >  	}
> >  
> > -	if (atomic_long_read(&mm->nr_ptes))
> > +	if (mm_nr_pmds(mm))
> 
> Should that be?
> 
> 	if (mm_nr_ptes(mm))

Thanks, for catching this.

-- 
 Kirill A. Shutemov