linux-kernel - Re: [PATCH v10 05/15] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171019180600.6gp7ch3z3bgbkqwt@pali>
Date:   Thu, 19 Oct 2017 20:06:00 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     dvhart@...radead.org, Andy Shevchenko <andy.shevchenko@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        Andy Lutomirski <luto@...nel.org>, quasisec@...gle.com,
        rjw@...ysocki.net, mjg59@...gle.com, hch@....de,
        Greg KH <greg@...ah.com>, Alan Cox <gnomes@...rguk.ukuu.org.uk>
Subject: Re: [PATCH v10 05/15] platform/x86: dell-wmi-descriptor: split WMI
 descriptor into it's own driver

On Thursday 19 October 2017 12:50:08 Mario Limonciello wrote:
> +	priv->interface_version = buffer[2];
> +	priv->size = buffer[3];
> +	ret = 0;
> +	dev_set_drvdata(&wdev->dev, priv);
> +	list_add_tail(&priv->list, &wmi_list);

Still missing lock when changing wmi_list.

> +
> +	dev_dbg(&wdev->dev, "Detected Dell WMI interface version %lu and buffer size %lu\n",
> +		(unsigned long) priv->interface_version,
> +		(unsigned long) priv->size);
> +
> +out:
> +	kfree(obj);
> +	return ret;
> +}

-- 
Pali Rohár
pali.rohar@...il.com